netdev - Re: [PATCH] net: fib: fix incorrect call_rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120808.155758.194423138369923978.davem@davemloft.net>
Date:	Wed, 08 Aug 2012 15:57:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH] net: fib: fix incorrect call_rcu_bh()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 07 Aug 2012 12:47:11 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> After IP route cache removal, I believe rcu_bh() has very little use and
> we should remove this RCU variant, since it adds some cycles in fast
> path.
> 
> Anyway, the call_rcu_bh() use in fib_true is obviously wrong, since
> some users only assert rcu_read_lock().
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html