netdev - RE: [PATCH] net: add new QCA alx ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6349D7A510622448B1BA0967850A84380136A1EF@NASANEXD02D.na.qualcomm.com>
Date:	Wed, 15 Aug 2012 03:29:26 +0000
From:	"Ren, Cloud" <cjren@....qualcomm.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	qca-linux-team <qca-linux-team@...lcomm.com>,
	nic-devel <nic-devel@...lcomm.com>,
	"Huang, Xiong" <xiong@....qualcomm.com>,
	"Hao-Ran Liu(Joseph Liu)" <hao-ran.liu@...onical.com>,
	Joe Perches <joe@...ches.com>,
	"Rodriguez, Luis" <rodrigue@....qualcomm.com>
Subject: RE: [PATCH] net: add new QCA alx ethernet driver

>> +	strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1);
>> ...
>> +	strcpy(netdev->name, "eth%d");
>> +	retval = register_netdev(netdev);
>
>The strcpy is unnecessary, alloc_etherdev already sets that.

The strcpy is useful. netdev->name is set as pci_name in front. So the strcpy restores it.

Thanks
cloud

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html