netdev - Re: [PATCH net 2/3] llc2: Call llc_station_exit() on llc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1345003593.824.212.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 15 Aug 2012 05:06:33 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	acme@...stprotocols.net, netdev@...r.kernel.org
Subject: Re: [PATCH net 2/3] llc2: Call llc_station_exit() on llc2_init()
 failure path

On Tue, 2012-08-14 at 16:52 -0700, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Mon, 13 Aug 2012 13:50:43 +0100
> 
> > Otherwise the station packet handler will remain registered even though
> > the module is unloaded.
> > 
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> 
> This will cause section mismatch errors, you'll need to remove
> the __exit tag from llc_station_exit() if you want to start
> invoking it from llc2_init() which is __init.
> 
> I took care of this when applying this patch to 'net'.

Thanks, David.

llc_station.c turns out to be mostly dead code, and I have some more
radical changes to remove that which I'll send after you next merge net
into net-next.

Ben.

-- 
Ben Hutchings
I say we take off; nuke the site from orbit.  It's the only way to be sure.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)