netdev - Re: IP fragmentation broken in 3.6-rc ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6-1L61YcoqJAnoq=BrbFvdrk3=mE4jwP9RBByE80p1zbLFiA@mail.gmail.com>
Date:	Tue, 21 Aug 2012 19:44:27 +0200
From:	Sylvain Munaut <s.munaut@...tever-company.com>
To:	unlisted-recipients:; (no To-header on input)
Cc:	netdev@...r.kernel.org
Subject: Re: IP fragmentation broken in 3.6-rc ?

Hi,

> Following patch should help :
>
> diff --git a/include/net/dst.h b/include/net/dst.h
> index 621e351..a04aa37 100644
> --- a/include/net/dst.h
> +++ b/include/net/dst.h
> @@ -435,7 +435,7 @@ static inline void dst_set_expires(struct dst_entry *dst, int timeout)
>         if (expires == 0)
>                 expires = 1;
>
> -       if (dst->expires == 0 || time_before(expires, dst->expires))
> +       if (dst->expires == 0 || time_after(expires, dst->expires))
>                 dst->expires = expires;
>  }

Yes, this fixes it for me too . ( 2h without issues on 2 different machines )

But that line has been in the kernel for _years_ ... so I'm not sure
what's going on there ...

Cheers,

    Sylvain
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html