netdev - Re: [PATCH v2] ipv4: Use newinet->inet_opt in inet_csk_route_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120821.144947.2102823805754391660.davem@davemloft.net>
Date:	Tue, 21 Aug 2012 14:49:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	christoph.paasch@...ouvain.be
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2] ipv4: Use newinet->inet_opt in
 inet_csk_route_child_sock()

From: Christoph Paasch <christoph.paasch@...ouvain.be>
Date: Mon, 20 Aug 2012 14:52:09 +0200

> Since 0e734419923bd ("ipv4: Use inet_csk_route_child_sock() in DCCP and
> TCP."), inet_csk_route_child_sock() is called instead of
> inet_csk_route_req().
> 
> However, after creating the child-sock in tcp/dccp_v4_syn_recv_sock(),
> ireq->opt is set to NULL, before calling inet_csk_route_child_sock().
> Thus, inside inet_csk_route_child_sock() opt is always NULL and the
> SRR-options are not respected anymore.
> Packets sent by the server won't have the correct destination-IP.
> 
> This patch fixes it by accessing newinet->inet_opt instead of ireq->opt
> inside inet_csk_route_child_sock().
> 
> Reported-by: Luca Boccassi <luca.boccassi@...il.com>
> Signed-off-by: Christoph Paasch <christoph.paasch@...ouvain.be>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html