netdev - Re: [PATCH] ipv4: fix ip header ident selection in __ip_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120821.145127.2073110448958014270.davem@davemloft.net>
Date:	Tue, 21 Aug 2012 14:51:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, shemminger@...tta.com,
	casteyde.christian@...e.fr
Subject: Re: [PATCH] ipv4: fix ip header ident selection in __ip_make_skb()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 20 Aug 2012 19:26:45 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Christian Casteyde reported a kmemcheck 32-bit read from uninitialized
> memory in __ip_select_ident().
> 
> It turns out that __ip_make_skb() called ip_select_ident() before
> properly initializing iph->daddr.
> 
> This is a bug uncovered by commit 1d861aa4b3fb (inet: Minimize use of
> cached route inetpeer.)
> 
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=46131
> 
> Reported-by: Christian Casteyde <casteyde.christian@...e.fr>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Stephen Hemminger <shemminger@...tta.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html