netdev - Re: [PATCH] libceph: Fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1208220852210.25274@cobra.newdream.net>
Date:	Wed, 22 Aug 2012 08:53:23 -0700 (PDT)
From:	Sage Weil <sage@...tank.com>
To:	Daniel Baluta <dbaluta@...acom.com>
cc:	davem@...emloft.net, ceph-devel@...r.kernel.org,
	netdev@...r.kernel.org, Iulius Curt <icurt@...acom.com>
Subject: Re: [PATCH] libceph: Fix sparse warning

On Wed, 22 Aug 2012, Daniel Baluta wrote:
> On Tue, Aug 14, 2012 at 4:27 PM, Iulius Curt <iulius.curt@...il.com> wrote:
> > From: Iulius Curt <iulius.curt@...il.com>
> >
> > Make ceph_monc_do_poolop() static to remove the following sparse warning:
> >  * net/ceph/mon_client.c:616:5: warning: symbol 'ceph_monc_do_poolop' was not
> >    declared. Should it be static?
> >
> > Signed-off-by: Iulius Curt <icurt@...acom.com>
> > ---
> >  net/ceph/mon_client.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/ceph/mon_client.c b/net/ceph/mon_client.c
> > index 105d533..3875c60 100644
> > --- a/net/ceph/mon_client.c
> > +++ b/net/ceph/mon_client.c
> > @@ -613,7 +613,7 @@ bad:
> >  /*
> >   * Do a synchronous pool op.
> >   */
> > -int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
> > +static int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op,
> >                         u32 pool, u64 snapid,
> >                         char *buf, int len)
> >  {
> > --
> > 1.7.9.5
> >
> > --
> 
> Hi Sage,
> 
> Can you have a look on this? :)

Sorry, this one fell through the cracks.  Yes, we can switch it to static, 
but while we're doing that let's drop the ceph_monc_ prefix too (since 
it's private).

Thanks!
sage
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html