netdev - Re: copy_skb_header() and sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1345612879.5158.569.camel@edumazet-glaptop>
Date:	Wed, 22 Aug 2012 07:21:19 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Kevin Wilson <wkevils@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: copy_skb_header() and sk_buff flags (question)

On Wed, 2012-08-22 at 07:55 +0300, Kevin Wilson wrote:
> Hello,
> 
> I have a question if I may, as I cannot understand this point:
> 
> I try to understand why in __copy_skb_header() we copy various flags
> (like ip_summed,
> local_df, pkt_type, priority, ipvs_property, and more. But there are
> flags which we do
> not copy, like nohdr, or fclone, or peeked.
> 
>  Aren't these flags part of the sk_buff header?

Caller should take care of said bits.

peeked is probably always 0 at this point...

I tried to use a single memcpy() to speedup things, but found out
it was not a trivial thing...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html