netdev - Re: [PATCH] net-tcp: fix cwnd reduction for non-sack recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120824.134951.1258077615464850610.davem@davemloft.net>
Date:	Fri, 24 Aug 2012 13:49:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ncardwell@...gle.com
Cc:	nanditad@...gle.com, ycheng@...gle.com, mattmathis@...gle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net-tcp: fix cwnd reduction for non-sack recovery

From: Neal Cardwell <ncardwell@...gle.com>
Date: Thu, 23 Aug 2012 13:25:50 -0400

> On Thu, Aug 23, 2012 at 1:21 PM, Nandita Dukkipati <nanditad@...gle.com> wrote:
>> On Thu, Aug 23, 2012 at 10:05 AM, Yuchung Cheng <ycheng@...gle.com> wrote:
>>> The cwnd reduction in fast recovery is based on the number of packets
>>> newly delivered per ACK. For non-sack connections every DUPACK
>>> signifies a packet has been delivered, but the sender mistakenly
>>> skips counting them for cwnd reduction.
>>>
>>> The fix is to compute newly_acked_sacked after DUPACKs are accounted
>>> in sacked_out for non-sack connections.
>>>
>>> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
 ...
>> Acked-by: Nandita Dukkipati <nanditad@...gle.com>
> 
> Acked-by: Neal Cardwell <ncardwell@...gle.com>

Applied, and queued up for -stable, thanks.

Please use plain "tcp: " as the prefix for pure tcp changes.  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html