netdev - Re: [net-next 11/13] igb: Update PTP function names/variables and locations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1345830987.32359.4.camel@joe2Laptop>
Date:	Fri, 24 Aug 2012 10:56:27 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	richardcochran@...il.com, matthew.vick@...el.com,
	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 11/13] igb: Update PTP function names/variables and
 locations.

On Fri, 2012-08-24 at 11:12 -0400, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Fri, 24 Aug 2012 02:22:34 -0700
> > On Fri, 2012-08-24 at 08:32 +0200, Richard Cochran wrote:
> >> On Thu, Aug 23, 2012 at 08:02:25PM -0700, Joe Perches wrote:
> >> > Improving code clarity and consistency isn't churn.
> >> This patch series moves code around for no good reason. That is, by
> >> definition, churn.
> > 
> > For your definition of good.
> 
> I think the people doing all of the actual development and
> maintainence of the code get to decide how to define good.  And in
> this case that's basically the Intel NIC development team, not you.

Just for clarity, you do mean Richard's view and not mine.
I agree with these proposed changes.

> Moving functions around is a very valuable and useful cleanup quite
> often.
> 
> So you can count me in on their definition of "good" as well.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html