netdev - Re: [RFC] Move in6_dev_hold under CONFIG_IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1346340321.2586.24.camel@edumazet-glaptop>
Date:	Thu, 30 Aug 2012 08:25:21 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Marchand <david.marchand@...e.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] Move in6_dev_hold under CONFIG_IPV6_PRIVACY

On Thu, 2012-08-30 at 11:42 +0200, David Marchand wrote:
> Hello,
> 
> I am currently looking at a problem with in6 interface refcnt on a 
> really old kernel and I have just noticed something I find suspicious in 
> all kernels until now.
> 
> The comment at net/ipv6/addrconf.c:396 suggests that the call to 
> in6_dev_hold is only for ipv6_regen_rndid.
> As a consequence, if CONFIG_IPV6_PRIVACY is not set, then this 
> in6_dev_hold will leak a refcnt.
> 
> Can someone look at this ?
> I did not test this patch, yet it looks reasonable to me.

Your patch was mangled by your email client, and its always safer to
test a patch...

Dont trust the comment, its a bit misleading.

Comment intent was to say :

/* One reference from device.  We must do this before
 * we eventually invoke __ipv6_regen_rndid().
 */



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html