netdev - Re: [PATCH net-next 0/12] qlcnic: patches for new adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120831.205308.538476490984218378.davem@davemloft.net>
Date:	Fri, 31 Aug 2012 20:53:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sony.chacko@...gic.com
Cc:	netdev@...r.kernel.org, Dept_NX_Linux_NIC_Driver@...gic.com
Subject: Re: [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic
 83XX CNA

From: David Miller <davem@...emloft.net>
Date: Fri, 31 Aug 2012 20:00:35 -0400 (EDT)

> From: Sony Chacko <sony.chacko@...gic.com>
> Date: Fri, 31 Aug 2012 18:36:47 -0400
> 
>> Please apply the updated patch series to net-next.
> 
> You posted too soon, you received other feedback in the
> mean-time which you should address as well.

Also in patch #5:

-		qlcnic_config_ipaddr(adapter, ifa->ifa_address, QLCNIC_IP_UP);
+		qlcnic_config_ipaddr(adapter, ifa->ifa_address,
+						 QLCNIC_IP_UP);

This is not the correct way to format multi-line function
calls, the correct way is:

		qlcnic_config_ipaddr(adapter, ifa->ifa_address,
				     QLCNIC_IP_UP);

That is, you line up the first character of the argument to
the column right after the openning parenthesis on the pevious
line, using the appropriate number of TAB and SPACE characters
necessary to achieve that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html