netdev - RE: [PATCH net-next 0/12] qlcnic: patches for new adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A26832265F3C994CBA2F7DA55BFAE70E74A06414B8@AVEXMB2.qlogic.org>
Date:	Fri, 31 Aug 2012 18:29:42 -0700
From:	Sony Chacko <sony.chacko@...gic.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev <netdev@...r.kernel.org>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: RE: [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic
 83XX CNA

Sorry about that. I will address all the issues in the next set of patches.
I am waiting for feedback from others as well.

Thanks,
Sony

-----Original Message-----
From: David Miller [mailto:davem@...emloft.net]
Sent: Friday, August 31, 2012 5:53 PM
To: Sony Chacko
Cc: netdev; Dept-NX Linux NIC Driver
Subject: Re: [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA

From: David Miller <davem@...emloft.net>
Date: Fri, 31 Aug 2012 20:00:35 -0400 (EDT)

> From: Sony Chacko <sony.chacko@...gic.com>
> Date: Fri, 31 Aug 2012 18:36:47 -0400
>
>> Please apply the updated patch series to net-next.
>
> You posted too soon, you received other feedback in the mean-time
> which you should address as well.

Also in patch #5:

-               qlcnic_config_ipaddr(adapter, ifa->ifa_address, QLCNIC_IP_UP);
+               qlcnic_config_ipaddr(adapter, ifa->ifa_address,
+                                                QLCNIC_IP_UP);

This is not the correct way to format multi-line function calls, the correct way is:

                qlcnic_config_ipaddr(adapter, ifa->ifa_address,
                                     QLCNIC_IP_UP);

That is, you line up the first character of the argument to the column right after the openning parenthesis on the pevious line, using the appropriate number of TAB and SPACE characters necessary to achieve that.

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html