netdev - Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50478F7E.1020606@chelsio.com>
Date:	Wed, 5 Sep 2012 23:14:30 +0530
From:	Naresh Kumar Inna <naresh@...lsio.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	"JBottomley@...allels.com" <JBottomley@...allels.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	Dimitrios Michailidis <dm@...lsio.com>,
	Casey Leedom <leedom@...lsio.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Chethan Seshadri <chethan@...lsio.com>
Subject: Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission
 (headers part 1).

On 9/5/2012 10:03 PM, Stephen Hemminger wrote:
> On Wed,  5 Sep 2012 18:03:59 +0530
> Naresh Kumar Inna <naresh@...lsio.com> wrote:
> 
>> +
>> +#define	CSIO_ASSERT(cond)						\
>> +do {									\
>> +	if (unlikely(!((cond))))					\
>> +		BUG();                                                  \
>> +} while (0)
>> +
> 
> Why is this not just BUG_ON(!(cond)) ?
> 

I will replace the 2 lines in the macro with BUG_ON() as you have
suggested. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html