lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120905155956.561b172d@nehalam.linuxnetplumber.net> Date: Wed, 5 Sep 2012 15:59:56 -0700 From: Stephen Hemminger <shemminger@...tta.com> To: Naresh Kumar Inna <naresh@...lsio.com> Cc: "JBottomley@...allels.com" <JBottomley@...allels.com>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, Dimitrios Michailidis <dm@...lsio.com>, Casey Leedom <leedom@...lsio.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Chethan Seshadri <chethan@...lsio.com> Subject: Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2). On Wed, 5 Sep 2012 23:13:46 +0530 Naresh Kumar Inna <naresh@...lsio.com> wrote: > On 9/5/2012 9:59 PM, Stephen Hemminger wrote: > > On Wed, 5 Sep 2012 18:03:55 +0530 > > Naresh Kumar Inna <naresh@...lsio.com> wrote: > > > >> This patch contains code for driver initialization, driver resource > >> allocation and the Work Request module functionality. Driver initialization > >> includes module entry/exit points, registration with PCI, FC transport and > >> SCSI mid layer subsystems. The Work Request module provides services for > >> allocation of DMA queues, posting Work Requests on them and processing > >> completions. > >> > >> Signed-off-by: Naresh Kumar Inna <naresh@...lsio.com> > > > > Although the comments say you are using proc fs, there is no > > code here related to that. > > I will remove that comment. > > > > > Any use of debugfs must be conditional the DEBUG_FS kernel configuration > > parameter. Your code probably will break if DEBUG_FS is not > > enabled. For a possible alternative see how a sub-config parameter > > was added in sky2 driver. > > > > It appears that debugfs_create_dir() returns an error if DEBUG_FS is not > enabled. Considering the driver handles this error and continues > initialization, do you still think I should guard this code within DEBUG_FS? > > Thanks. That works, just make sure and test it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists