netdev - Re: [PATCH] net: Small bug on rxhash calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1346913733.13121.179.camel@edumazet-glaptop>
Date:	Thu, 06 Sep 2012 08:42:13 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Chema Gonzalez <chema@...keley.edu>
Cc:	netdev <netdev@...r.kernel.org>, edumazet@...gle.com,
	Chema Gonzalez <chema@...gle.com>
Subject: Re: [PATCH] net: Small bug on rxhash calculation

On Wed, 2012-09-05 at 23:35 -0700, Chema Gonzalez wrote:
> From 5c02179069826bfba9360383b88601b31ff05517 Mon Sep 17 00:00:00 2001
> From: Chema Gonzalez <chema@...gle.com>
> Date: Wed, 5 Sep 2012 17:05:48 -0700
> Subject: [PATCH] net: Small bug on rxhash calculation
> 
> While the (current) sorting of the ports/addresses is coherent
> (you get the same rxhash for packets sharing the same (unsorted)
> 4-tuple), ports and addresses should not be sorted independently,
> which currently are: For traffic between A=S:l and B=L:s, packets
> in both directions would get their rxhash from hashing
> {L, S, {s, l}}. The same rxhash is obtained from packets between
> C=S:s and D=L:l.
> 
> This patch ensures traffic between A and B gets their rxhash
> from {S, L, {s, l}}, and traffic between C and D from {S, L,
> {l, s}}
> 
> The patch is co-written with Eric Dumazet <edumazet@...gle.com>
> 
> Signed-off-by: Chema Gonzalez <chema@...gle.com>
> ---

Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html