netdev - Re: [PATCH] usbnet: drop unneeded check for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120906075255.GC2550@netboy.at.omicron.at>
Date:	Thu, 6 Sep 2012 09:52:55 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>, oneukum@...e.de,
	netdev@...r.kernel.org,
	Alexander Duyck <alexander.h.duyck@...el.com>
Subject: Re: [PATCH] usbnet: drop unneeded check for NULL

On Wed, Sep 05, 2012 at 11:14:35PM +0100, Ben Hutchings wrote:
> 
> Perhaps the skb_tx_timestamp() call should be moved below the
> 'if (info->tx_fixup)' block, at which point skb is definitely non-null.

No, that block shuffles the packet alignment all around, and spoils
any code which needs to match packets with time stamps.

> It doesn't look like cdc-ncm will provide useful timestamps either way.

But it is not the only user of this code. Furthermore, the PHY driver
will want a chance to provide a HW time stamp in any case.

Thanks,
Richard


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html