lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Sep 2012 09:19:22 +0800 From: Cong Wang <amwang@...hat.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org Subject: Re: [PATCH 2/3] ipv6, route: remove BACKTRACK() macro On Mon, 2012-09-10 at 16:32 -0400, David Miller wrote: > From: Cong Wang <amwang@...hat.com> > Date: Mon, 10 Sep 2012 20:48:45 +0800 > > > It doesn't save any code, nor it helps readability. > > > > Signed-off-by: Cong Wang <amwang@...hat.com> > > I'm not applying this. > > Having two copies of the same exact logic means we will accumulate > bugs in the future if someone fixes the problem only in one > copy. Makes sense, but BACKTRACK() is not well written, as it jumps out of its definition. :( Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists