lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 11 Sep 2012 09:22:53 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Shan Wei <shanwei88@...il.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 2/3] ipv6, route: remove BACKTRACK() macro

On Mon, 2012-09-10 at 21:43 +0800, Shan Wei wrote:
> Cong Wang said, at 2012/9/10 20:48:
> > It doesn't save any code, nor it helps readability.
> > 
> > Signed-off-by: Cong Wang <amwang@...hat.com>
> 
> this macro, don't reduce showing lines?
> with it, more readability on terminal, right?

I can't agree, try to read the goto inside, you have to scroll your
screen down when you read the second BACTRACK().

> 
> P.S. when doing backport work, some bored patches influence me.
> this patch and [PATCH 3/3] are typical. :-)
> 

Why not just cherry-pick it too? `git cherry-pick` is handy. ;)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists