[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <B4C805E1-3390-4002-BECC-7D1AFF2BD56D@gmail.com>
Date: Thu, 13 Sep 2012 15:45:14 -0400
From: Andres Lagar-Cavilla <andres.lagarcavilla@...il.com>
To: Ian Campbell <Ian.Campbell@...rix.com>
Cc: Andres Lagar-Cavilla <andres@...arcavilla.org>,
"xen-devel@....lists.org" <xen-devel@....lists.org>,
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
David Vrabel <david.vrabel@...rix.com>,
David Miller <davem@...emloft.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] Xen backend support for paged out grant targets.
On Sep 13, 2012, at 2:11 PM, Ian Campbell wrote:
> On Thu, 2012-09-13 at 18:28 +0100, Andres Lagar-Cavilla wrote:
>>
>> * Add placeholder in array of grant table error descriptions for
>> unrelated error code we jump over.
>
> Why not just define it, it's listed here:
> http://xenbits.xen.org/docs/unstable/hypercall/include,public,grant_table.h.html#Enum_grant_status
Well, a) we'd be defining something no one will be using (for the moment) b) I would be signing-off on something unrelated.
>
> I notice the specific wording of the error msg is different here too.
That should not be, I'll re-spin the patch.
Thanks
Andres
> It'd probably be best to use the same wording as the Xen definition, so
> all OSes end up with the same name for the same condition (else bug
> reports will be confusing).
>
> Ian.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists