netdev - Re: [PATCH] mISDN: Fix wrong usage of flush_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Sep 2012 21:50:49 +0200
From:	Karsten Keil <kkeil@...ux-pingi.de>
To:	David Miller <davem@...emloft.net>
CC:	keil@...systems.de, netdev@...r.kernel.org
Subject: Re: [PATCH] mISDN: Fix wrong usage of flush_work_sync while holding
 locks

Am 13.09.2012 21:06, schrieb David Miller:
> From: David Miller <davem@...emloft.net>
> Date: Thu, 13 Sep 2012 14:59:37 -0400 (EDT)
> 
>> From: Karsten Keil <keil@...systems.de>
>> Date: Thu, 13 Sep 2012 16:36:20 +0200
>>
>>> It is a bad idea to hold a spinlock and call flush_work_sync.
>>> Move the workqueue cleanup outside the spinlock and use cancel_work_sync,
>>> on closing the channel this seems to be the more correct function.
>>> Remove the never used and constant return value of mISDN_freebchannel.
>>>
>>> Signed-off-by: Karsten Keil <keil@...systems.de>
>>> Cc: <stable@...nel.org>
>>
>> Applied, thanks.
> 
> BTW, about -stable:
> 
> 1) Even if it were appropriate to submit this directly to -stable,
>    stable@...nel.org is not the correct email address and you must
>    have seen the bounce produced by trying to send email there.
> 
>    Rather, stable@...r.kernel.org is the correct address.
> 
> 2) I queue up and submit networking bug fixes for -stable myself so
>    you should not submit them directly but rather make a request that
>    I add your patch to my networking -stable queue.
> 

OK, then I will put something like, "Should be considered for stable
too" in the comment and do not add the CC: stable@...r.kernel.org
for the next time.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html