netdev - Re: [PATCH v1 0/19] qlcnic: patches for new adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Sep 2012 18:47:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sony.chacko@...gic.com
Cc:	netdev@...r.kernel.org, Dept_NX_Linux_NIC_Driver@...gic.com
Subject: Re: [PATCH v1 0/19] qlcnic: patches for new adapter - Qlogic 83XX
 CNA

I tired reviewing this driver just for coding style issues after just
looking at two or three of them.

I hope that it is no surprise to you that people are very reluctant to
review this driver at all, given how much basic stylistic issues
remain.

I haven't even begun to think about the actual technical semantics and
correctness of these patches.  I doubt anyone else in the community
had either, and that won't even begin to happen until the coding style
issues are rectified.

You guys have a long, very long, way to go with this patch set.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html