netdev - Re: [PATCH] ipv6: fix return value check in fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120921.134435.90667959444720339.davem@davemloft.net>
Date:	Fri, 21 Sep 2012 13:44:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	weiyj.lk@...il.com
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, yongjun_wei@...ndmicro.com.cn,
	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: fix return value check in fib6_add()

From: Wei Yongjun <weiyj.lk@...il.com>
Date: Fri, 21 Sep 2012 12:29:56 +0800

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> In case of error, the function fib6_add_1() returns ERR_PTR()
> or NULL pointer. The ERR_PTR() case check is missing in fib6_add().
> 
> dpatch engine is used to generated this patch.
> (https://github.com/weiyj/dpatch)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Applied, thanks.

Longer term fib6_add_1() should consistently return errno pointers,
rather than a mixture of NULL and errno pointers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html