netdev - Re: [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120921.134215.1719885507288305623.davem@davemloft.net>
Date:	Fri, 21 Sep 2012 13:42:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	marex@...x.de
Cc:	netdev@...r.kernel.org, david.choi@...rel.com,
	nobuhiro.iwamatsu.yj@...esas.com, fabio.estevam@...escale.com,
	shawn.guo@...aro.org
Subject: Re: [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021

From: Marek Vasut <marex@...x.de>
Date: Fri, 21 Sep 2012 04:52:54 +0200

> +	phy_write(phydev, MII_KSZPHY_OMSO,
> +		KSZPHY_OMSO_B_CAST_OFF | KSZPHY_OMSO_RMII_OVERRIDE);

This is not indented properly.  The goal is not to exclusively use
TAB characters to indent code until it sort-of looks fine.

Rather, the goal is to properly line up function arguments with
the first column after the openning parenthesis on the previous
line.  Using TAB and SPACE characters, as needed.

> +	.features	= (PHY_BASIC_FEATURES | SUPPORTED_Pause
> +				| SUPPORTED_Asym_Pause),

This is similarly not styled properly.

Besies being indented imporperly on the second line, the final "|"
character should be at the end of the first line, rather than
start the second line.

Resubmit this entire patch series, not just this one patch, once
you've made these corrections.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html