netdev - Re: [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201209212004.10148.marex@denx.de>
Date:	Fri, 21 Sep 2012 20:04:09 +0200
From:	Marek Vasut <marex@...x.de>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, david.choi@...rel.com,
	nobuhiro.iwamatsu.yj@...esas.com, fabio.estevam@...escale.com,
	shawn.guo@...aro.org
Subject: Re: [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021

Dear David Miller,

> From: Marek Vasut <marex@...x.de>
> Date: Fri, 21 Sep 2012 04:52:54 +0200
> 
> > +	phy_write(phydev, MII_KSZPHY_OMSO,
> > +		KSZPHY_OMSO_B_CAST_OFF | KSZPHY_OMSO_RMII_OVERRIDE);
> 
> This is not indented properly.  The goal is not to exclusively use
> TAB characters to indent code until it sort-of looks fine.

The goal was to avoid checkpatch trouble.

> Rather, the goal is to properly line up function arguments with
> the first column after the openning parenthesis on the previous
> line.  Using TAB and SPACE characters, as needed.
> 
> > +	.features	= (PHY_BASIC_FEATURES | SUPPORTED_Pause
> > +				| SUPPORTED_Asym_Pause),
> 
> This is similarly not styled properly.

This is copy-pasted from other entry. I'd hate to reformat the whole file.

> Besies being indented imporperly on the second line, the final "|"
> character should be at the end of the first line, rather than
> start the second line.

DTTO here.

> Resubmit this entire patch series, not just this one patch, once
> you've made these corrections.
> 
> Thanks.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html