| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAL8zT=hJ84woFg0KFxztuTxf2NJEBzThPRXDhZ9KnMJnBxmoZA@mail.gmail.com>
Date: Tue, 25 Sep 2012 14:22:49 +0200
From: Jean-Michel Hautbois <jhautbois@...il.com>
To: Dmitry Kravkov <dmitry@...adcom.com>
Cc: netdev <netdev@...r.kernel.org>,
Barak Witkowski <barak@...adcom.com>,
Eilon Greenstein <eilong@...adcom.com>,
"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: bnx2x: link detected up at startup even when it should be down
2012/9/25 Dmitry Kravkov <dmitry@...adcom.com>:
>> -----Original Message-----
>> From: Jean-Michel Hautbois [mailto:jhautbois@...il.com]
>> Sent: Tuesday, September 25, 2012 10:11 AM
>> To: Dmitry Kravkov
>> Cc: netdev; Barak Witkowski; Eilon Greenstein; davem@...emloft.net
>> Subject: Re: bnx2x: link detected up at startup even when it should be down
>>
>>
>> I have tested several things, and I added some traces in order to get
>> information.
>> For instance, I trace the load_code in the function named "bnx2x_nic_load".
>>
>> [ 25.693677] bnx2x 0000:04:00.0: eth0: bnx2x_nic_load load_code=0x10130000
>> [ 25.693679] bnx2x 0000:04:00.0: eth0: bnx2x_nic_load start period
>> [ 102.748934] bnx2x 0000:04:00.1: eth1: bnx2x_nic_load load_code=0x10100000
>> [ 102.749065] bnx2x 0000:04:00.1: eth1: bnx2x_nic_load start period
>> [ 104.007074] bnx2x 0000:04:00.2: eth2: bnx2x_nic_load load_code=0x10120000
>> [ 104.007197] bnx2x 0000:04:00.2: eth2: bnx2x_nic_load NOT start period
>> [ 104.423789] bnx2x 0000:04:00.3: eth3: bnx2x_nic_load load_code=0x10120000
>> [ 104.423914] bnx2x 0000:04:00.3: eth3: bnx2x_nic_load NOT start period
>> [ 104.836505] bnx2x 0000:04:00.4: eth4: bnx2x_nic_load load_code=0x10120000
>> [ 104.836632] bnx2x 0000:04:00.4: eth4: bnx2x_nic_load NOT start period
>> [ 105.254220] bnx2x 0000:04:00.5: eth5: bnx2x_nic_load load_code=0x10120000
>> [ 105.254350] bnx2x 0000:04:00.5: eth5: bnx2x_nic_load NOT start period
>> [ 105.667935] bnx2x 0000:04:00.6: eth6: bnx2x_nic_load load_code=0x10120000
>> [ 105.668066] bnx2x 0000:04:00.6: eth6: bnx2x_nic_load NOT start period
>> [ 106.081652] bnx2x 0000:04:00.7: eth7: bnx2x_nic_load load_code=0x10120000
>> [ 106.081779] bnx2x 0000:04:00.7: eth7: bnx2x_nic_load NOT start period
>>
>> This is a FlexNIC use.
>> Here is my (quick and dirty) patch which makes the link detection
>> working and adds the traces shown above :
>>
>> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
>> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
>> index 580b44e..dedd810 100644
>> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
>> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
>> @@ -1769,6 +1769,7 @@ int bnx2x_nic_load(struct bnx2x *bp, int load_mode)
>> */
>> if (!BP_NOMCP(bp)) {
>> load_code = bnx2x_fw_command(bp, DRV_MSG_CODE_LOAD_REQ, 0);
>> +netdev_info(bp->dev, "bnx2x_nic_load bnx2x_fw_command
>> load_code=0x%08X\n",load_code);
>> if (!load_code) {
>> BNX2X_ERR("MCP response failure, aborting\n");
>> rc = -EBUSY;
>> @@ -1785,22 +1786,31 @@ int bnx2x_nic_load(struct bnx2x *bp, int load_mode)
>> DP(NETIF_MSG_IFUP, "NO MCP - load counts[%d] %d, %d, %d\n",
>> path, load_count[path][0], load_count[path][1],
>> load_count[path][2]);
>> +netdev_info(bp->dev, "bnx2x_nic_load NO MCP - load counts[%d]
>> %d, %d, %d\n",
>> + path, load_count[path][0], load_count[path][1],
>> + load_count[path][2]);
>> load_count[path][0]++;
>> load_count[path][1 + port]++;
>> DP(NETIF_MSG_IFUP, "NO MCP - new load counts[%d] %d, %d, %d\n",
>> path, load_count[path][0], load_count[path][1],
>> load_count[path][2]);
>> +netdev_info(bp->dev, "bnx2x_nic_load NO MCP - new load counts[%d]
>> %d, %d, %d\n",
>> + path, load_count[path][0], load_count[path][1],
>> + load_count[path][2]);
>> if (load_count[path][0] == 1)
>> load_code = FW_MSG_CODE_DRV_LOAD_COMMON;
>> else if (load_count[path][1 + port] == 1)
>> load_code = FW_MSG_CODE_DRV_LOAD_PORT;
>> else
>> load_code = FW_MSG_CODE_DRV_LOAD_FUNCTION;
>> +netdev_info(bp->dev, "bnx2x_nic_load autre
>> load_code=0x%08X\n",load_code);
>> }
>>
>> +netdev_info(bp->dev, "bnx2x_nic_load load_code=0x%08X\n",load_code);
>> if ((load_code == FW_MSG_CODE_DRV_LOAD_COMMON) ||
>> (load_code == FW_MSG_CODE_DRV_LOAD_COMMON_CHIP) ||
>> - (load_code == FW_MSG_CODE_DRV_LOAD_PORT)) {
>> + (load_code == FW_MSG_CODE_DRV_LOAD_PORT) ||
>> + (load_code == FW_MSG_CODE_DRV_LOAD_FUNCTION)) {
>> bp->port.pmf = 1;
>> /*
>> * We need the barrier to ensure the ordering between the
>> @@ -1808,9 +1818,13 @@ int bnx2x_nic_load(struct bnx2x *bp, int load_mode)
>> * bnx2x_periodic_task().
>> */
>> smp_mb();
>> +netdev_info(bp->dev, "bnx2x_nic_load start period\n");
>> queue_delayed_work(bnx2x_wq, &bp->period_task, 0);
>> } else
>> +{
>> +netdev_info(bp->dev, "bnx2x_nic_load NOT start period\n");
>> bp->port.pmf = 0;
>> +}
>>
>> DP(NETIF_MSG_LINK, "pmf %d\n", bp->port.pmf);
>>
> Thanks Jean,
> But your output does not suit the patch.
Yes, you are right, here it is :
Sep 25 07:56:08 debian kernel: [ 26.607197] bnx2x 0000:04:00.0:
eth0: bnx2x_nic_load bnx2x_fw_command load_code=0x10130000
Sep 25 07:56:08 debian kernel: [ 26.608642] bnx2x 0000:04:00.0:
eth0: bnx2x_nic_load load_code=0x10130000
Sep 25 07:56:08 debian kernel: [ 26.608644] bnx2x 0000:04:00.0:
eth0: bnx2x_nic_load start period
Sep 25 07:57:20 debian kernel: [ 101.068231] bnx2x 0000:04:00.1:
eth1: bnx2x_nic_load bnx2x_fw_command load_code=0x10100000
Sep 25 07:57:20 debian kernel: [ 101.068416] bnx2x 0000:04:00.1:
eth1: bnx2x_nic_load load_code=0x10100000
Sep 25 07:57:20 debian kernel: [ 101.068533] bnx2x 0000:04:00.1:
eth1: bnx2x_nic_load start period
Sep 25 07:57:21 debian kernel: [ 102.294393] bnx2x 0000:04:00.2:
eth2: bnx2x_nic_load bnx2x_fw_command load_code=0x10120000
Sep 25 07:57:21 debian kernel: [ 102.294585] bnx2x 0000:04:00.2:
eth2: bnx2x_nic_load load_code=0x10120000
Sep 25 07:57:21 debian kernel: [ 102.294711] bnx2x 0000:04:00.2:
eth2: bnx2x_nic_load start period
Sep 25 07:57:22 debian kernel: [ 102.782057] bnx2x 0000:04:00.3:
eth3: bnx2x_nic_load bnx2x_fw_command load_code=0x10120000
Sep 25 07:57:22 debian kernel: [ 102.782240] bnx2x 0000:04:00.3:
eth3: bnx2x_nic_load load_code=0x10120000
Sep 25 07:57:22 debian kernel: [ 102.782359] bnx2x 0000:04:00.3:
eth3: bnx2x_nic_load start period
Sep 25 07:57:22 debian kernel: [ 103.265731] bnx2x 0000:04:00.4:
eth4: bnx2x_nic_load bnx2x_fw_command load_code=0x10120000
Sep 25 07:57:22 debian kernel: [ 103.265924] bnx2x 0000:04:00.4:
eth4: bnx2x_nic_load load_code=0x10120000
Sep 25 07:57:22 debian kernel: [ 103.266051] bnx2x 0000:04:00.4:
eth4: bnx2x_nic_load start period
Sep 25 07:57:23 debian kernel: [ 103.758390] bnx2x 0000:04:00.5:
eth5: bnx2x_nic_load bnx2x_fw_command load_code=0x10120000
Sep 25 07:57:23 debian kernel: [ 103.758583] bnx2x 0000:04:00.5:
eth5: bnx2x_nic_load load_code=0x10120000
Sep 25 07:57:23 debian kernel: [ 103.758711] bnx2x 0000:04:00.5:
eth5: bnx2x_nic_load start period
Sep 25 07:57:23 debian kernel: [ 104.252053] bnx2x 0000:04:00.6:
eth6: bnx2x_nic_load bnx2x_fw_command load_code=0x10120000
Sep 25 07:57:23 debian kernel: [ 104.252247] bnx2x 0000:04:00.6:
eth6: bnx2x_nic_load load_code=0x10120000
Sep 25 07:57:23 debian kernel: [ 104.252373] bnx2x 0000:04:00.6:
eth6: bnx2x_nic_load start period
Sep 25 07:57:24 debian kernel: [ 104.836655] bnx2x 0000:04:00.7:
eth7: bnx2x_nic_load bnx2x_fw_command load_code=0x10120000
Sep 25 07:57:24 debian kernel: [ 104.836849] bnx2x 0000:04:00.7:
eth7: bnx2x_nic_load load_code=0x10120000
Sep 25 07:57:24 debian kernel: [ 104.836976] bnx2x 0000:04:00.7:
eth7: bnx2x_nic_load start period
Sep 25 07:57:25 debian kernel: [ 106.145755] bnx2x 0000:04:00.1:
eth1: bnx2x_nic_load bnx2x_fw_command load_code=0x10120000
Sep 25 07:57:25 debian kernel: [ 106.145940] bnx2x 0000:04:00.1:
eth1: bnx2x_nic_load load_code=0x10120000
Sep 25 07:57:25 debian kernel: [ 106.146056] bnx2x 0000:04:00.1:
eth1: bnx2x_nic_load start period
> Your patch will start periodic for every instance, but printout show that it's started for PMF only (which is correct).
> Generally if all functions are marked as PMF (port management function) you will get into the problem accessing shared port resources, like phys and internal data structures, then configuration/data will be corrupted.
>
> Is it feasible to provide ethtool -i output and syslog when driver is loaded debug=0x4?
$> ethtool -i eth0
driver: bnx2x
version: 1.70.30-1
firmware-version: bc 7.0.49
bus-info: 0000:04:00.0
And msglvl set to 4 says this :
Sep 25 12:29:20 debian kernel: [16410.336897] bnx2x:
[bnx2x_get_settings:251(eth0)]ethtool_cmd: cmd 1
Sep 25 12:29:20 debian kernel: [16410.337215] bnx2x:
[bnx2x_get_settings:251(eth1)]ethtool_cmd: cmd 1
Sep 25 12:29:20 debian kernel: [16410.337511] bnx2x:
[bnx2x_get_settings:251(eth2)]ethtool_cmd: cmd 1
Sep 25 12:29:21 debian kernel: [16410.395363] bnx2x:
[bnx2x_set_aer_mmd:3342(eth1)]Set AER to 0x2
Sep 25 12:29:21 debian kernel: [16410.633207] bnx2x:
[bnx2x_set_aer_mmd:3342(eth0)]Set AER to 0x0
Sep 25 12:29:21 debian kernel: [16411.174842] bnx2x:
[bnx2x_set_aer_mmd:3342(eth2)]Set AER to 0x0
Sep 25 12:29:22 debian kernel: [16411.396739] bnx2x:
[bnx2x_set_aer_mmd:3342(eth1)]Set AER to 0x2
Sep 25 12:29:22 debian kernel: [16411.432249] bnx2x:
[bnx2x_get_settings:251(eth0)]ethtool_cmd: cmd 1
Sep 25 12:29:22 debian kernel: [16411.432566] bnx2x:
[bnx2x_get_settings:251(eth1)]ethtool_cmd: cmd 1
Sep 25 12:29:22 debian kernel: [16411.433348] bnx2x:
[bnx2x_get_settings:251(eth2)]ethtool_cmd: cmd 1
Sep 25 12:29:22 debian kernel: [16411.634797] bnx2x:
[bnx2x_set_aer_mmd:3342(eth0)]Set AER to 0x0
Sep 25 12:29:22 debian kernel: [16412.176170] bnx2x:
[bnx2x_set_aer_mmd:3342(eth2)]Set AER to 0x0
Sep 25 12:29:23 debian kernel: [16412.408747] bnx2x:
[bnx2x_set_aer_mmd:3342(eth1)]Set AER to 0x2
Sep 25 12:29:23 debian kernel: [16412.489861] bnx2x:
[bnx2x_get_settings:251(eth0)]ethtool_cmd: cmd 1
Sep 25 12:29:23 debian kernel: [16412.490182] bnx2x:
[bnx2x_get_settings:251(eth1)]ethtool_cmd: cmd 1
Sep 25 12:29:23 debian kernel: [16412.490505] bnx2x:
[bnx2x_get_settings:251(eth2)]ethtool_cmd: cmd 1
Sep 25 12:29:23 debian kernel: [16412.635849] bnx2x:
[bnx2x_set_aer_mmd:3342(eth0)]Set AER to 0x0
Sep 25 12:29:23 debian kernel: [16413.177496] bnx2x:
[bnx2x_set_aer_mmd:3342(eth2)]Set AER to 0x0
Sep 25 12:29:24 debian kernel: [16413.411329] bnx2x:
[bnx2x_set_aer_mmd:3342(eth1)]Set AER to 0x2
JM
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists