netdev - Re: [PATCH] bnx2: Clean up remaining iounmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348684433.7220.78.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
Date:	Wed, 26 Sep 2012 11:33:53 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Neil Horman" <nhorman@...driver.com>
cc:	netdev@...r.kernel.org, "Michael Chan" <mcan@...adcom.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] bnx2: Clean up remaining iounmap

On Wed, 2012-09-26 at 13:22 -0400, Neil Horman wrote: 
> commit c0357e975afdbbedab5c662d19bef865f02adc17 modified bnx2 to switch from
> using ioremap/iounmap to pci_iomap/pci_iounmap.  They missed a spot in the error
> path of bnx2_init_one though.  This patch just cleans that up.
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>
> CC: Michael Chan <mcan@...adcom.com>
> CC: "David S. Miller" <davem@...emloft.net>

Acked-by: Michael Chan <mchan@...adcom.com>

> ---
>  drivers/net/ethernet/broadcom/bnx2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c
> index 79cebd8..e48312f 100644
> --- a/drivers/net/ethernet/broadcom/bnx2.c
> +++ b/drivers/net/ethernet/broadcom/bnx2.c
> @@ -8564,7 +8564,7 @@ bnx2_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	return 0;
>  
>  error:
> -	iounmap(bp->regview);
> +	pci_iounmap(pdev, bp->regview);
>  	pci_release_regions(pdev);
>  	pci_disable_device(pdev);
>  	pci_set_drvdata(pdev, NULL);



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html