netdev - Re: [PATCH v5 01/10] ipc: remove forced assignment of selected message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Sep 2012 12:37:18 -0500
From:	Serge Hallyn <serge.hallyn@...onical.com>
To:	Stanislav Kinsbursky <skinsbursky@...allels.com>
Cc:	akpm@...ux-foundation.org, manfred@...orfullife.com,
	a.p.zijlstra@...llo.nl, netdev@...r.kernel.org,
	will.deacon@....com, linux-kernel@...r.kernel.org,
	cmetcalf@...era.com, jmorris@...ei.org, linux-driver@...gic.com,
	linux-security-module@...r.kernel.org, hughd@...gle.com,
	ron.mercer@...gic.com, viro@...iv.linux.org.uk,
	james.l.morris@...cle.com, catalin.marinas@....com,
	casey@...aufler-ca.com, eparis@...isplace.org, sds@...ho.nsa.gov,
	jitendra.kalsaria@...gic.com, devel@...nvz.org
Subject: Re: [PATCH v5 01/10] ipc: remove forced assignment of selected
 message

Quoting Stanislav Kinsbursky (skinsbursky@...allels.com):
> This is a cleanup patch. The assignment is redundant.
> 
> Signed-off-by: Stanislav Kinsbursky <skinsbursky@...allels.com>
> ---
>  ipc/msg.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/ipc/msg.c b/ipc/msg.c
> index 7385de2..f3bfbb8 100644
> --- a/ipc/msg.c
> +++ b/ipc/msg.c
> @@ -787,7 +787,6 @@ long do_msgrcv(int msqid, long *pmtype, void __user *mtext,
>  			    !security_msg_queue_msgrcv(msq, walk_msg, current,
>  						       msgtyp, mode)) {
>  
> -				msg = walk_msg;
>  				if (mode == SEARCH_LESSEQUAL &&
>  						walk_msg->m_type != 1) {
>  					msg = walk_msg;

Perhaps your tree is different from mine, but it looks to me like it would
be simpler to remove the 'msg = walk_msg' from both the 'if' and 'else',
and keep them above the if/else?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html