[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120926172614.GA22353@1984>
Date: Wed, 26 Sep 2012 19:26:14 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Stephen Hemminger <shemminger@...tta.com>
Cc: Gao feng <gaofeng@...fujitsu.com>, davem@...emloft.net,
netfilter-devel@...r.kernel.org, linux-rdma@...r.kernel.org,
netdev@...r.kernel.org, eric.dumazet@...il.com,
steffen.klassert@...unet.com, linux-crypto@...r.kernel.org,
jengelh@...i.de, stephen.hemminger@...tta.com
Subject: Re: [PATCH 02/11] inet_diag: pass inet_diag module to
netlink_dump_start
On Wed, Sep 26, 2012 at 09:07:14AM -0700, Stephen Hemminger wrote:
> On Wed, 26 Sep 2012 12:52:11 +0800
> Gao feng <gaofeng@...fujitsu.com> wrote:
>
> > struct netlink_dump_control c = {
> > .dump = inet_diag_dump_compat,
> > + .done = netlink_dump_done,
> > + .module = THIS_MODULE,
> > };
>
> Since these are immutable, why the netlink_dump_control structures
> on the stack (which requires code to generate at runtime), and instead
> make them global
>
> static const struct netlink_dump_control unix_diag_ctrl = {
> ...
I made that code. I can send a patch to statify those
netlink_dump_control structures.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists