netdev - Re: [PATCH 02/11] inet_diag: pass inet_diag module to netlink_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120926090714.618a4b39@nehalam.linuxnetplumber.net>
Date:	Wed, 26 Sep 2012 09:07:14 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Gao feng <gaofeng@...fujitsu.com>
Cc:	davem@...emloft.net, netfilter-devel@...r.kernel.org,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	eric.dumazet@...il.com, pablo@...filter.org,
	steffen.klassert@...unet.com, linux-crypto@...r.kernel.org,
	jengelh@...i.de, stephen.hemminger@...tta.com
Subject: Re: [PATCH 02/11] inet_diag: pass inet_diag module to
 netlink_dump_start

On Wed, 26 Sep 2012 12:52:11 +0800
Gao feng <gaofeng@...fujitsu.com> wrote:

>  			struct netlink_dump_control c = {
>  				.dump = inet_diag_dump_compat,
> +				.done = netlink_dump_done,
> +				.module = THIS_MODULE,
>  			};

Since these are immutable, why the netlink_dump_control structures
on the stack (which requires code to generate at runtime), and instead
make them global

static const struct netlink_dump_control unix_diag_ctrl = {
...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html