lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAKh2mn5shRWNXzj0BotxqfM2EJUM9UBQfUsXVqdd63eiWo0S-Q@mail.gmail.com> Date: Thu, 27 Sep 2012 09:04:51 +0100 From: Steve Glendinning <steve@...well.net> To: Bjørn Mork <bjorn@...k.no> Cc: netdev@...r.kernel.org Subject: Re: [PATCH 5/5] smsc95xx: enable power saving mode during system suspend On 26 September 2012 17:17, Bjørn Mork <bjorn@...k.no> wrote: > Yes, but you are a lot less likely to know about it if you BUG out. The > user will be left with no other choice than hitting reset or poweroff. > What's the point of that? > > If your driver crashes but the machine is left running, then the user > may forward the Oops to you. That's much more useful. Good point, I hadn't considered that. So for user reportability am I better off to use WARN_ON in this case, or simply remove the check and let the null pointer dereference happen? -Steve -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists