netdev - Re: [PATCH 5/5] smsc95xx: enable power saving mode during system suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k3vfz8u5.fsf@nemi.mork.no>
Date:	Thu, 27 Sep 2012 19:14:42 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Steve Glendinning <steve@...well.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/5] smsc95xx: enable power saving mode during system suspend

Steve Glendinning <steve@...well.net> writes:
> On 26 September 2012 17:17, Bjørn Mork <bjorn@...k.no> wrote:
>> Yes, but you are a lot less likely to know about it if you BUG out.  The
>> user will be left with no other choice than hitting reset or poweroff.
>> What's the point of that?
>>
>> If your driver crashes but the machine is left running, then the user
>> may forward the Oops to you.  That's much more useful.
>
> Good point, I hadn't considered that.
>
> So for user reportability am I better off to use WARN_ON in this case,
> or simply remove the check and let the null pointer dereference
> happen?

Exactly.  See also http://permalink.gmane.org/gmane.linux.kernel/1365689


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html