netdev - RE: [PATCH v2] net: ti cpsw ethernet: set IFCTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Oct 2012 10:52:01 +0000
From:	"N, Mugunthan V" <mugunthanvnm@...com>
To:	Daniel Mack <zonque@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Hiremath, Vaibhav" <hvaibhav@...com>,
	"David S. Miller" <davem@...emloft.net>
Subject: RE: [PATCH v2] net: ti cpsw ethernet: set IFCTL_A bit in MACCONTROL

> -----Original Message-----
> From: Daniel Mack [mailto:zonque@...il.com]
> Sent: Monday, October 01, 2012 2:55 PM
> To: Daniel Mack
> Cc: netdev@...r.kernel.org; N, Mugunthan V; Hiremath, Vaibhav; David S.
> Miller
> Subject: Re: [PATCH v2] net: ti cpsw ethernet: set IFCTL_A bit in
> MACCONTROL
> 
> On 27.09.2012 21:19, Daniel Mack wrote:
> > For RMII/RGMII mode operation in 100Mbps, the CPSW needs to set the
> > IFCTL_A bits in the MACCONTROL register. For all other PHY modes,
> this
> > bit is unused, so setting it unconditionally shouldn't cause any
> > trouble.
> >
> > Signed-off-by: Daniel Mack <zonque@...il.com>
> > Cc: Mugunthan V N <mugunthanvnm@...com>
> > Cc: Vaibhav Hiremath <hvaibhav@...com>
> > Cc: David S. Miller <davem@...emloft.net>
> 
> Mugunthan, are you ok with this version? Don't know if it's too late
> for
> the 3.7 spin though, given that the merge window just opened.
> 
> 
> Daniel

I am ok with the patch

Regards
Mugunthan V N

> 
> 
> > ---
> >  drivers/net/ethernet/ti/cpsw.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/ti/cpsw.c
> b/drivers/net/ethernet/ti/cpsw.c
> > index aa78168..fb1a692 100644
> > --- a/drivers/net/ethernet/ti/cpsw.c
> > +++ b/drivers/net/ethernet/ti/cpsw.c
> > @@ -386,6 +386,11 @@ static void _cpsw_adjust_link(struct cpsw_slave
> *slave,
> >  			mac_control |= BIT(7);	/* GIGABITEN	*/
> >  		if (phy->duplex)
> >  			mac_control |= BIT(0);	/* FULLDUPLEXEN	*/
> > +
> > +		/* set speed_in input in case RMII mode is used in 100Mbps
> */
> > +		if (phy->speed == 100)
> > +			mac_control |= BIT(15);
> > +
> >  		*link = true;
> >  	} else {
> >  		mac_control = 0;
> >