netdev - Re: [patch] net/key/af_key.c: add range checks on ->sadb_x_policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121001.171531.1225138780751285845.davem@davemloft.net>
Date:	Mon, 01 Oct 2012 17:15:31 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	ebiederm@...ssion.com, eric.dumazet@...il.com,
	shemminger@...tta.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] net/key/af_key.c: add range checks on
 ->sadb_x_policy_len

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Fri, 28 Sep 2012 11:21:19 +0300

> Because sizeof() is size_t then if "len" is negative, it counts as a
> large positive value.
> 
> The call tree looks like:
> pfkey_sendmsg()
> -> pfkey_process()
>    -> pfkey_spdadd()
>       -> parse_ipsecrequests()
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> This is a static checker fix.  I'm not very familiar with this code.
> I think if we were to hit this then we would try to parse invalid data
> and it would return -EINVAL or similar error code pretty quickly.

Applied and queued up for -stable, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html