lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 7 Oct 2012 08:32:09 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Eric Dumazet <eric.dumazet@...il.com> Cc: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, Jesse Gross <jesse@...ira.com>, Tom Herbert <therbert@...gle.com>, Yuchung Cheng <ycheng@...gle.com> Subject: Re: [PATCH] net: gro: selective flush of packets On Sat, Oct 06, 2012 at 08:08:49PM +0200, Eric Dumazet wrote: > > @@ -3981,8 +3996,17 @@ static void net_rx_action(struct softirq_action *h) > local_irq_enable(); > napi_complete(n); > local_irq_disable(); > - } else > + } else { > + if (n->gro_list) { > + /* flush too old packets > + * If HZ < 1000, flush all packets. > + */ > + local_irq_enable(); > + napi_gro_flush(n, HZ >= 1000); > + local_irq_disable(); > + } > list_move_tail(&n->poll_list, &sd->poll_list); > + } Why don't we just always flush everything? Thanks, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists