[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20121006.171748.734171045678392820.davem@davemloft.net>
Date: Sat, 06 Oct 2012 17:17:48 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: haicheng.li@...ux.intel.com
Cc: fengguang.wu@...el.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [net:master 1/9] pch_gbe_main.c:(.text+0x510370): undefined
reference to `pch_ch_control_write'
From: Haicheng Li <haicheng.li@...ux.intel.com>
Date: Sun, 07 Oct 2012 01:21:09 +0800
> Take IXGBE_PTP as example, it explicitly selects PPS, and also depends
> on EXPERIMENTAL:
> config IXGBE_PTP
> bool "PTP Clock Support"
> default n
> depends on IXGBE && EXPERIMENTAL
> select PPS
> select PTP_1588_CLOCK
>
> So if you stick to use "select" as the convention of such build issue
> fixing, fengguang's build failure would be fixed by:
> + depends on EXPERIMENTAL
> + select PPS
> + select PTP_1588_CLOCK
>
> would you prefer this way?
Yes, I would.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists