netdev - Re: [PATCH] net/ethernet/jme: disable ASPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121008.153953.2134806395029777705.davem@davemloft.net>
Date:	Mon, 08 Oct 2012 15:39:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mjg59@...f.ucam.org
Cc:	kevin.baradon@...il.com, cooldavid@...ldavid.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net/ethernet/jme: disable ASPM

From: Matthew Garrett <mjg59@...f.ucam.org>
Date: Mon, 8 Oct 2012 20:33:16 +0100

> On Mon, Oct 08, 2012 at 03:24:26PM -0400, David Miller wrote:
> 
>> This should be a PCI quirk shouldn't it?
> 
> No, it's a driver-level policy decision.

Then at a bare minimum this change should be using one of the ASPM
helpers provided by drivers/pci/pcie/aspm.c such as
pci_disable_link_state().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html