netdev - Re: [PATCH] net/ethernet/jme: disable ASPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121010225049.024c94cb@laptop-kevin.kbaradon.com>
Date:	Wed, 10 Oct 2012 22:50:49 +0200
From:	Kevin Baradon <kevin.baradon@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	mjg59@...f.ucam.org, cooldavid@...ldavid.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net/ethernet/jme: disable ASPM

Le Mon, 08 Oct 2012 15:39:53 -0400 (EDT),
David Miller <davem@...emloft.net> a écrit :

> From: Matthew Garrett <mjg59@...f.ucam.org>
> Date: Mon, 8 Oct 2012 20:33:16 +0100
> 
> > On Mon, Oct 08, 2012 at 03:24:26PM -0400, David Miller wrote:
> > 
> >> This should be a PCI quirk shouldn't it?
> > 
> > No, it's a driver-level policy decision.
> 
> Then at a bare minimum this change should be using one of the ASPM
> helpers provided by drivers/pci/pcie/aspm.c such as
> pci_disable_link_state().

pci_disable_link_state() is already used in this patch.
Am I missing something else?

Below you will find updated patch with corrected indentation.

-- >8 --
Subject: [PATCH] net/ethernet/jme: disable ASPM

Based on patch from Matthew Garrett <mjg@...hat.com> (https://lkml.org/lkml/2011/11/11/168).

http://driveragent.com/archive/30421/7-0-14 indicates that ASPM is
disabled on the 250 and 260. Duplicate for sanity.

Fixes random RX engine hangs I experienced with JMC250 on Clevo W270HU.

Signed-off-by: Kevin Baradon <kevin.baradon@...il.com>
Cc: Guo-Fu Tseng <cooldavid@...ldavid.org>
Cc: Matthew Garrett <mjg@...hat.com>
Cc: netdev@...r.kernel.org
---
 drivers/net/ethernet/jme.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index c911d88..f8064df 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -27,6 +27,7 @@
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/pci.h>
+#include <linux/pci-aspm.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
@@ -2973,6 +2974,9 @@ jme_init_one(struct pci_dev *pdev,
 	/*
 	 * set up PCI device basics
 	 */
+	pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | PCIE_LINK_STATE_L1 |
+			       PCIE_LINK_STATE_CLKPM);
+
 	rc = pci_enable_device(pdev);
 	if (rc) {
 		pr_err("Cannot enable PCI device\n");
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html