netdev - Re: [PATCH v1] net/core: support runtime PM on net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121018.150548.538241834379627262.davem@davemloft.net>
Date:	Thu, 18 Oct 2012 15:05:48 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ming.lei@...onical.com
Cc:	bjorn@...k.no, rjw@...k.pl, oneukum@...e.de,
	stern@...land.harvard.edu, netdev@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH v1] net/core: support runtime PM on net_device

From: Ming Lei <ming.lei@...onical.com>
Date: Thu, 18 Oct 2012 20:55:58 +0800

> On Thu, Oct 18, 2012 at 7:40 PM, Bjørn Mork <bjorn@...k.no> wrote:
>>
>> Because bugs are supposed to be fixed and not hidden?
> 
> OK, now let's discuss solution for the problem which should be
> clear and be solved.
> 
> The 1st one is to do it by this patch, or rule out some ioctl cmd
> which needn't wakeup device.
> 
> The second one is to fix ioctl one by one in each driver.
> 
> Any other solution?

The second is clearly the correct way to handle these issues.

Drivers need to be aware when their drivers ops are called whether
they can safely access the device or not.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html