[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACVXFVNXFEg0kiFb6RGfS9grYvyuRL-=jiqEdxDEnn0Avwpw9Q@mail.gmail.com>
Date: Fri, 19 Oct 2012 09:45:04 +0800
From: Ming Lei <ming.lei@...onical.com>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: Bjørn Mork <bjorn@...k.no>,
"David S. Miller" <davem@...emloft.net>,
"Rafael J. Wysocki" <rjw@...k.pl>, Oliver Neukum <oneukum@...e.de>,
Alan Stern <stern@...land.harvard.edu>, netdev@...r.kernel.org,
linux-pm@...r.kernel.org
Subject: Re: [PATCH v1] net/core: support runtime PM on net_device
On Fri, Oct 19, 2012 at 12:34 AM, Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
> Hi Ming,
>
> IIUC, the pm_runtime is related to the device drivers, so at the first
> glance, we should see invocation of the runtime's functions in drivers/*
> and arch/*. Adding these calls in the net core, which makes sense at a
> certain point, is a bit weird for me.
>
> From my POV, if the drivers have been modified to support the pm_runtime
> and this new functionality brought a regression with the ioctl, that
> should be fixed in the drivers and not in the core code.
>
> What happens with your patch if we use ethtool on a virtual device like
> veth, macvlan, bridge, ... ?
No any effect no matter if these drivers implement runtime PM or not.
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists