netdev - Re: [PATCH] gianfar_ptp: use iomem, not ioports resource tree in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50883D03.1000600@windriver.com>
Date:	Wed, 24 Oct 2012 15:09:55 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Tabi Timur-B04825 <B04825@...escale.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Wei Yang <Wei.Yang@...driver.com>,
	Manoil Claudiu-B08782 <B08782@...escale.com>
Subject: Re: [PATCH] gianfar_ptp: use iomem, not ioports resource tree in
 probe

On 12-10-24 01:59 PM, Tabi Timur-B04825 wrote:
> On Wed, Oct 24, 2012 at 10:21 AM, Paul Gortmaker
> <paul.gortmaker@...driver.com> wrote:
>> From: Wei Yang <Wei.Yang@...driver.com>
>>
>> When using a 36 bit dtb file, the driver complains "resource busy".
>>
>> Investigating the source of the message leads one to the
>> gianfar_ptp_probe function.
>>
>> Since the type of the device resource requested in this function
>> is IORESOURCE_MEM, it should use "iomem_resource" instead of
>> "ioports_resource".
> 
> I can't comment on this patch, since I didn't write the driver, but I
> am confused on one thing.  Why is the driver using platform_xxx calls

Even if it makes sense to convert the driver to of_xxx calls,
I think the obvious bug should be fixed as a separate commit,
so that the -stable folks have something to cherry pick.

P.
--

> to get data?  Why isn't it using of_xxx calls to read properties from
> the device tree?  For example, why is it using
> 
> 	etsects->irq = platform_get_irq(dev, 0);
> 
> to get the IRQ?  Shouldn't it do this instead:
> 
> 	etsects->irq = irq_of_parse_and_map(node, 0);
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html