netdev - Re: [RFC PATCH net-next v2 2/5] rtnl/ipv6: use netconf msg to advertise forwarding status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121026.051719.783711995394609246.davem@davemloft.net>
Date:	Fri, 26 Oct 2012 05:17:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	David.Laight@...LAB.COM
Cc:	nicolas.dichtel@...nd.com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-next v2 2/5] rtnl/ipv6: use netconf msg to
 advertise forwarding status

From: "David Laight" <David.Laight@...LAB.COM>
Date: Fri, 26 Oct 2012 10:03:54 +0100

>> > +static inline int inet6_netconf_msgsize_devconf(int type)
>> 
>> Outside of header files, we don't add explicit inlines, we let
>> the compiler decide.
> 
> Hmmm.... In my experience it makes bad decisions,
> even for static functions that are only called once.
> And yes, I have checked that the inlined code is smaller
> and faster.

This isn't for you to decide.  It's been decided long ago that we're
doing things tree wide doing things this way.

If GCC is not perfect, submit a well formed bug report, don't complain
here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html