netdev - Re: tcp_metrics: dumb bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121031.124639.2059872320833955948.davem@davemloft.net>
Date:	Wed, 31 Oct 2012 12:46:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	ja@....bg, netdev@...r.kernel.org
Subject: Re: tcp_metrics: dumb bug

From: Stephen Hemminger <shemminger@...tta.com>
Date: Tue, 30 Oct 2012 08:59:20 -0700

> https://bugzilla.kernel.org/show_bug.cgi?id=49171
> 
> Description From David Binderman 2012-10-21 10:31:05 (-) [reply]
> The source code is
> 
>         if (nla_len(a) != sizeof(sizeof(struct in6_addr)))
> 
> I'm surprised that compiles. Suggest remove one of the sizeofs.

sizeof() resolves to a size_t value so... :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html