netdev - Re: [Suggestion] net-ipv6: format %8s change to %16s in rt6_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1351760482.32673.913.camel@edumazet-glaptop>
Date:	Thu, 01 Nov 2012 10:01:22 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [Suggestion] net-ipv6: format %8s change to %16s in
 rt6_info_route function of route.c

On Thu, 2012-11-01 at 14:45 +0800, Chen Gang wrote:
> Hello:
> 
> 1) For Public Kernel:
> 
>    A) in rt6_info_route function of net/ipv6/route.c
> 
>    B) the length of rt->rt6i_dev->name is 16 (IFNAMSIZ)
> 
>    C) using %16s is better than %8s (it will be more "beautiful")
>       (also suggest to delete RT6_INFO_LEN, it is useless for ever)
> 
> 
> 
> 2) For Red Hat RHEL5:
> 
>    A) in rt6_info_route function of net/ipv6/route.c
> 
>    B) the length of rt->rt6i_dev->name is 16 (IFNAMSIZ)
> 
>    C) for RT6_INFO_LEN is still useful, so it is an correctness issue.
> 
>    the relative patch for RHEL5 is below:

Hi Chen

Thats a good suggestion indeed.

Networking patches should be sent to netdev@...r.kernel.org (added in
CC)

This list only cares about recent generic kernels, not RedHat ones.

If you want to provide a patch, please base it on David Miller net-next
[1] tree, and make it official (read Documentation/SubmittingPatches for
general advices)

By the way, the %8s should be replaced by %s, there is no need to make
/proc/net/ipv6_route 'beautiful'. In the past, it was *needed* because
each line had to be of a given length, but its not anymore the case.

Thanks

[1] :
http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=summary


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html