netdev - Re: [PATCH v2] af-packet: fix oops when socket is not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1352205772.3140.1025.camel@edumazet-glaptop>
Date:	Tue, 06 Nov 2012 04:42:52 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Eric Leblond <eric@...it.org>, netdev <netdev@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] af-packet: fix oops when socket is not present

On Tue, 2012-11-06 at 13:28 +0100, Greg KH wrote:
> On Tue, Nov 06, 2012 at 01:10:10PM +0100, Eric Leblond wrote:
> > Due to a NULL dereference, the following patch is causing oops
> > in normal trafic condition:
> > 
> > commit c0de08d04215031d68fa13af36f347a6cfa252ca
> > Author: Eric Leblond <eric@...it.org>
> > Date:   Thu Aug 16 22:02:58 2012 +0000
> > 
> >     af_packet: don't emit packet on orig fanout group
> > 
> > This buggy patch was a feature fix and has reached most stable
> > branches.
> > 
> > When skb->sk is NULL and when packet fanout is used, there is a
> > crash in match_fanout_group where skb->sk is accessed.
> > This patch fixes the issue by returning false as soon as the
> > socket is NULL: this correspond to the wanted behavior because
> > the kernel as to resend the skb to all the listening socket in
> > this case.
> > 
> > Signed-off-by: Eric Leblond <eric@...it.org>
> > ---
> >  net/core/dev.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
> 
> </formletter>

Right.

By the way, David Miller prefers to handle stable submissions himself.

So Eric, I guess you could just do nothing for this particular patch,
since your stable@...r.kernel.org addition in the CC will be void.

(Dont add the Cc: in the patch itself, as David will remove it anyway)

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html