netdev - Re: [PATCH v2] af-packet: fix oops when socket is not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121107.154248.205807168678683505.davem@davemloft.net>
Date:	Wed, 07 Nov 2012 15:42:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric@...it.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2] af-packet: fix oops when socket is not present

From: Eric Leblond <eric@...it.org>
Date: Tue,  6 Nov 2012 13:10:10 +0100

> Due to a NULL dereference, the following patch is causing oops
> in normal trafic condition:
> 
> commit c0de08d04215031d68fa13af36f347a6cfa252ca
> Author: Eric Leblond <eric@...it.org>
> Date:   Thu Aug 16 22:02:58 2012 +0000
> 
>     af_packet: don't emit packet on orig fanout group
> 
> This buggy patch was a feature fix and has reached most stable
> branches.
> 
> When skb->sk is NULL and when packet fanout is used, there is a
> crash in match_fanout_group where skb->sk is accessed.
> This patch fixes the issue by returning false as soon as the
> socket is NULL: this correspond to the wanted behavior because
> the kernel as to resend the skb to all the listening socket in
> this case.
> 
> Signed-off-by: Eric Leblond <eric@...it.org>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html