netdev - Re: [net-next 04/11] ixgbevf: Add flag to indicate when rx is in net poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121113.142005.106273728495001348.davem@davemloft.net>
Date:	Tue, 13 Nov 2012 14:20:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	gregory.v.rose@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com
Subject: Re: [net-next 04/11] ixgbevf: Add flag to indicate when rx is in
 net poll

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 13 Nov 2012 06:03:18 -0800

> From: Greg Rose <gregory.v.rose@...el.com>
> 
> napi_gro_receive shouldn't be called from netpoll context.  Doing
> so was causing kernel panics when jumbo frames larger than 2K were set.
> Add a flag to check if the Rx ring processing is occurring from interrupt
> context or from netpoll context and call netif_rx() if in the polling
> context.
> 
> Signed-off-by: Greg Rose <gregory.v.rose@...el.com>
> Tested-by: Sibai Li <sibai.li@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

This is not a scalable solution.

It is not prudent to have every single driver do a check like
this.  If using GRO receive from netpoll causes problems,
then it's a generic issue rather than a driver specific one.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html