netdev - Re: [PATCH] drivers/net: fix tasklet misuse issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121114.215055.1156530698069105896.davem@davemloft.net>
Date:	Wed, 14 Nov 2012 21:50:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xtfeng@...il.com
Cc:	dannyfeng@...cent.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/net: fix tasklet misuse issue

From: Xiaotian Feng <xtfeng@...il.com>
Date: Wed, 14 Nov 2012 13:47:36 +0800

> In commit 175c0dff, drivers uses tasklet_kill to avoid put disabled tasklet
> on the tasklet vec. But some of the drivers uses tasklet_init & tasklet_disable
> in the driver init code, then tasklet_enable when it is opened. This makes
> tasklet_enable on a killed tasklet and make ksoftirqd crazy then. Normally,
> drivers should use tasklet_init/tasklet_kill on device open/remove, and use
> tasklet_disable/tasklet_enable on device suspend/resume.
> 
> Reported-by: Peter Wu <lekensteyn@...il.com>
> Tested-by: Peter Wu <lekensteyn@...il.com>
> Signed-off-by: Xiaotian Feng <dannyfeng@...cent.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html