netdev - Re: [PATCH] net: phy: smsc: Re-enable EDPD mode for LAN87xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121115.203452.167702404507991690.davem@davemloft.net>
Date:	Thu, 15 Nov 2012 20:34:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	marex@...x.de
Cc:	patrick.trantham@...l7.com, netdev@...r.kernel.org,
	steve.glendinning@...well.net, otavio@...ystems.com.br,
	chohnstaedt@...ominate.com, jkosina@...e.cz
Subject: Re: [PATCH] net: phy: smsc: Re-enable EDPD mode for LAN87xx

From: Marek Vasut <marex@...x.de>
Date: Fri, 16 Nov 2012 01:04:33 +0100

> Dear David Miller,
> 
>> From: Patrick Trantham <patrick.trantham@...l7.com>
>> Date: Thu, 15 Nov 2012 13:00:57 -0600
>> 
>> > This patch re-enables Energy Detect Power Down (EDPD) mode for the
>> > LAN8710/LAN8720.  EDPD mode was disabled in a previous commit,
>> > (b629820d18fa65cc598390e4b9712fd5f83ee693), because it was causing the
>> > PHY to not be able to detect a link when cold started without a cable
>> > connected.
>> > 
>> > The LAN8710/LAN8720 requires a minimum of 2 link pulses within 64ms of
>> > each other in order to set the ENERGYON bit and exit EDPD mode.  If a
>> > link partner does send the pulses within this interval, the PHY will
>> > remained powered down.
>> > 
>> > This workaround will manually toggle the PHY on/off upon calls to
>> > read_status in order to generate link test pulses if the link is down.
>> > If a link partner is present, it will respond to the pulses, which will
>> > cause the ENERGYON bit to be set and will cause the EDPD mode to be
>> > exited.
>> > 
>> > Signed-off-by: Patrick Trantham <patrick.trantham@...l7.com>
>> 
>> Applied to net-next, thanks.
> 
> Can you please wait a bit until it gets a few tests ?

This is net-next, we have months to take care of this before
it really ends up in Linus's tree.

It's already commited to the public record and therefore the change
cannot be "un-commited" once I push it out to one of my GIT trees.  I
never rebase.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html