netdev - Re: [PATCH 080/493] fddi: remove use of __devexit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Nov 2012 19:16:44 +0000 (GMT)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Bill Pemberton <wfp5p@...ginia.edu>
cc:	gregkh@...uxfoundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH 080/493] fddi: remove use of __devexit_p

On Mon, 19 Nov 2012, Maciej W. Rozycki wrote:

> > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> > needed.
> 
>  Shouldn't this be switching to __exit_p() instead?  Likewise all the 
> other changes concerned (i.e. s/__dev\(init\|exit\)/__\1/), for the sake 
> of drivers built into the kernel proper (yes, there are people out there 
> still doing that).  Am I missing something?
> 
>  This change scores my NAK as it stands, until updated accordingly or 
> further justified.

 I have unconfused myself now, so please replace the above with the 
following question: what about configurations (e.g. buses) that not 
support hotplug at all?  For example apart from PCI the defxx driver 
concerned here supports the TURBOchannel bus that by design does not have 
the concept of live option card removal (no such circuitry).  So should 
now the precious memory be wasted on systems that will never ever handle 
hotplug?

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html